Let checkers and IDEs know that pywintypes and pythoncom are actually dynamic modules
#2418
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
changed the title
misc + name-definedmisc + name-defined + attr-defined
Avasam
commented
Oct 23, 2024
Avasam
changed the title
misc + name-defined + attr-definedmisc + name-defined + attr-defined by clearly making pythoncom.py and pywintypes.py dynamic
Avasam
changed the title
misc + name-defined + attr-defined by clearly making pythoncom.py and pywintypes.py dynamicmisc+name-defined+attr-defined and pyright reportAttributeAccessIssue by clearly making pythoncom.py and pywintypes.py dynamic
Avasam
changed the title
misc+name-defined+attr-defined and pyright reportAttributeAccessIssue by clearly making pythoncom.py and pywintypes.py dynamicmisc+name-defined+attr-defined and pyright reportAttributeAccessIssue from pythoncom.py and pywintypes.py
…reportAttributeAccessIssue`
Avasam
force-pushed
the
mypy-fix-and-re-enable-misc-+-name-defined
branch
from
11a6602 to
e828797
Compare
…fix-and-re-enable-misc-+-name-defined
…fix-and-re-enable-misc-+-name-defined
Avasam
changed the title
misc+name-defined+attr-defined and pyright reportAttributeAccessIssue from pythoncom.py and pywintypes.pypywintypes and pythoncom are actually dynamic modules
Avasam
force-pushed
the
mypy-fix-and-re-enable-misc-+-name-defined
branch
from
b2d2352 to
5c43fc9
Compare
Avasam
changed the title
pywintypes and pythoncom are actually dynamic modulespywintypes and pythoncom are actually dynamic modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
def __getattr__(name: str) -> Any: ...is the same technique typeshed uses for incomplete and dynamic stubsFixes plenty of attribute access issues concerning
pywintypesandpythoncomas (incorrectly) found by different checkers (mypy, pyright, pylint, etc.) and language servers (Pylance, PyCharm, ...) both for pywin32 internally and users of pywin32.(internally this also solves a handful of mypy's
misc,name-defined,attr-defined, and pyright'sreportAttributeAccessIssuewarnings)